Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: completion was being called with wrong data types #4324

Merged
merged 2 commits into from May 20, 2023

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented May 20, 2023

Background

Using self feedback was crashing Auto-GPT
See #4275 for more details

Changes

Fix the parameters being passed to the create_chat_completion within self feedback

Documentation

N/A

Test Plan

Tested the relevant codepath manually

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run black . and isort . against my code to ensure it passes our linter.

@ntindle ntindle linked an issue May 20, 2023 that may be closed by this pull request
1 task
@vercel
Copy link

vercel bot commented May 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 20, 2023 9:11pm

@ntindle ntindle added this to the v0.3.2 Release milestone May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (023a50d) 63.26% compared to head (af7fd0b) 63.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4324   +/-   ##
=======================================
  Coverage   63.26%   63.26%           
=======================================
  Files          74       74           
  Lines        3427     3427           
  Branches      504      504           
=======================================
  Hits         2168     2168           
  Misses       1103     1103           
  Partials      156      156           
Impacted Files Coverage Δ
autogpt/agent/agent.py 58.49% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ntindle ntindle requested a review from k-boikov May 20, 2023 21:53
@ntindle ntindle merged commit c30f5b7 into master May 20, 2023
11 checks passed
@ntindle ntindle deleted the 4275-using-s-for-self-feedback-crashes branch May 20, 2023 23:04
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Using 's' for self-feedback crashes
2 participants