Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spinning to be disabled #4329

Merged

Conversation

k-boikov
Copy link
Contributor

Background

Test output is bloated from the Spinner
image

Changes

Allow spinning to be disabled. Disable spinning in tests.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run black . and isort . against my code to ensure it passes our linter.

@vercel
Copy link

vercel bot commented May 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 26, 2023 8:50pm

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (e7c0d33) 67.71% compared to head (f68e31b) 67.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4329   +/-   ##
=======================================
  Coverage   67.71%   67.72%           
=======================================
  Files          72       72           
  Lines        3528     3535    +7     
  Branches      557      559    +2     
=======================================
+ Hits         2389     2394    +5     
- Misses        955      956    +1     
- Partials      184      185    +1     
Impacted Files Coverage Δ
autogpt/spinner.py 92.30% <84.61%> (-4.67%) ⬇️
autogpt/agent/agent.py 59.50% <100.00%> (ø)
autogpt/commands/file_operations.py 83.62% <100.00%> (ø)
autogpt/config/config.py 76.35% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-boikov k-boikov added this to the v0.3.2 Release milestone May 21, 2023
.env.template Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview May 22, 2023 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview May 25, 2023 18:40 Inactive
Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to PLAIN_OUTPUT

@ntindle
Copy link
Member

ntindle commented May 26, 2023

Open an issue to apply this to typewriter text too

@k-boikov
Copy link
Contributor Author

Open an issue to apply this to typewriter text too

For the typing delay?

@k-boikov k-boikov merged commit 064e95b into Significant-Gravitas:master May 26, 2023
11 checks passed
@ntindle
Copy link
Member

ntindle commented May 26, 2023

Yes

@k-boikov k-boikov deleted the improvement/do-not-spin branch May 26, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants