Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vcr to dalle #4474

Merged
merged 1 commit into from May 30, 2023
Merged

add vcr to dalle #4474

merged 1 commit into from May 30, 2023

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented May 30, 2023 •
edited

Background

Dalle wasn't using VCR

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters: 
    black .
isort .
mypy
autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports autogpt tests --in-place

@vercel
Copy link

vercel bot commented May 30, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 30, 2023 4:32am

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented May 30, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: +0.14 🎉

Comparison is base (56650b6) 68.57% compared to head (1eb718a) 68.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4474      +/-   ##
==========================================
+ Coverage   68.57%   68.72%   +0.14%     
==========================================
  Files          72       72              
  Lines        3520     3520              
  Branches      561      561              
==========================================
+ Hits         2414     2419       +5     
+ Misses        921      916       -5     
  Partials      185      185

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi marked this pull request as draft May 30, 2023 02:39
@github-actions github-actions bot added size/s and removed size/xs labels May 30, 2023
@waynehamadi waynehamadi force-pushed the add-vcr-to-dalle branch 2 times, most recently from 3ec0196 to b854c72 Compare May 30, 2023 04:31
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@waynehamadi waynehamadi marked this pull request as ready for review May 30, 2023 04:38
@waynehamadi waynehamadi merged commit 22429c6 into Significant-Gravitas:master May 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-boikov k-boikov k-boikov approved these changes

Assignees
No one assigned
Labels
behaviour change size/s
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waynehamadi @Auto-GPT-Bot @k-boikov