Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replace_in_file command to change occurrences of text in a file #4565

Merged
merged 7 commits into from
Jun 4, 2023
Merged

Add replace_in_file command to change occurrences of text in a file #4565

merged 7 commits into from
Jun 4, 2023

Conversation

bfalans
Copy link
Contributor

@bfalans bfalans commented Jun 3, 2023 •
edited
Loading

Background

See #3643

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters: 
    black .
isort .
mypy
autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports autogpt tests --in-place

@vercel
Copy link

vercel bot commented Jun 3, 2023

Deployment failed with the following error:

Resource is limited - try again in 29 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot added the size/l label Jun 3, 2023
erik-megarad
erik-megarad reviewed Jun 4, 2023
View reviewed changes
autogpt/commands/file_operations.py Outdated Show resolved Hide resolved
autogpt/commands/file_operations.py Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jun 4, 2023

Deployment failed with the following error:

Resource is limited - try again in 42 minutes (more than 100, code: "api-deployments-free-per-day").

Pwuts
Pwuts requested changes Jun 4, 2023
View reviewed changes
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the previous incarnation of the PR, I would like to see a good example of the agent using this command in an effective way.

autogpt/commands/file_operations.py Outdated Show resolved Hide resolved
autogpt/commands/file_operations.py Outdated Show resolved Hide resolved
waynehamadi
waynehamadi previously approved these changes Jun 4, 2023
View reviewed changes
@vercel
Copy link

vercel bot commented Jun 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 4, 2023 5:27pm

@Pwuts
Copy link
Member

Pwuts commented Jun 4, 2023

Still some failing tests, but all seem unrelated to this change, so I say merge

@Pwuts Pwuts changed the title update_file method to change occurences of text in a file Add replace_in_file command to change occurrences of text in a file Jun 4, 2023
@Pwuts Pwuts added this to the v0.4.1 Release milestone Jun 4, 2023
@Pwuts Pwuts self-assigned this Jun 4, 2023
@Pwuts Pwuts merged commit 74e8a88 into Significant-Gravitas:master Jun 4, 2023
7 of 8 checks passed
kuwork added a commit to kuwork/Auto-GPT that referenced this pull request Jun 12, 2023
@kuwork
Merge branch 'cn-dev' into cn
7dbedd3 
* cn-dev: (64 commits)
  针对国内的情况，翻译成中文
  Update challenge scores
  Update version numbers for v0.4.0 release
  Add `replace_in_file` command (Significant-Gravitas#4565)
  Update bulletin with highlights for v0.4.0 release (Significant-Gravitas#4576)
  Skip flaky challenges (Significant-Gravitas#4573)
  Fix `test_web_selenium` (Significant-Gravitas#4554)
  Clean up CI git logic
  remove information retrieval challenge b from beaten challenges
  Fix CI git authentication and cassettes
  debug
  Fix CI git diff
  Fix CI git authorization
  Update submodule reference
  Update current score
  Cache Python Packages in the CI pipeline (Significant-Gravitas#4488)
  Fix pushing cassettes in CI
  Remove news about config (Significant-Gravitas#4553)
  Fix CI for internal PRs with CI changes (Significant-Gravitas#4552)
  Update BULLETIN.md
  ...

# Conflicts:
#	BULLETIN.md
#	CONTRIBUTING.md
#	autogpt/agent/agent.py
#	autogpt/app.py
#	autogpt/llm/llm_utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-megarad erik-megarad erik-megarad left review comments

@Pwuts Pwuts Pwuts approved these changes

@waynehamadi waynehamadi waynehamadi left review comments

Assignees

@Pwuts Pwuts

Labels
size/l
Projects
AutoGPT development kanban
Archived in project
Milestone
v0.4.1 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bfalans @Pwuts @erik-megarad @waynehamadi