Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix the benchmarking #5194

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Trying to fix the benchmarking #5194

merged 4 commits into from
Sep 12, 2023

Conversation

Swiftyos
Copy link
Contributor

@Swiftyos Swiftyos commented Sep 11, 2023

Currently not in a working state:

Objective:

  1. add a metadata field to the challenges json file, that is just added to the report.json
  2. add an answers field to the report.json which contains the out artifact contents.

Evolving Objective:

  1. Get benchmarking running in the mono repo
  2. Avoid module name conflicts. -> renamed to benchmark, removed the install lines in the pyproject
  3. Renamed config.json to benchmark_config.json so we can have this in the root of an agents directory.
  4. [Incomplete] entry_path is now a path relative to the benchmark_config file for the python file that when run runs the agent
  5. Added in a pedantic class for handling benchmark_config.json
  6. stripped out the global configured paths as they had many assumptions baked into them. Was trying to use the AgentBenchmarkConfig class (5) and pass that around. Though instead needed to pass the path around from sys.argv and kept loading the AgentBenchmarkConfig (bad)
  7. Had to remove git hash stuff as the agent repos do are not git root dirs. - easy to fix but hadn't made the required modifications.

Current state:

/Users/swifty/dev/Auto-GPT/benchmark/benchmark/challenges/verticals/synthesize/r3/data.json
Generated test for TestRetrieval3.
===================================================================== test session starts ======================================================================
platform darwin -- Python 3.11.5, pytest-7.4.2, pluggy-1.3.0 -- /Users/swifty/Library/Caches/pypoetry/virtualenvs/auto-gpt-0lbXQRmL-py3.11/bin/python
cachedir: .pytest_cache
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /Users/swifty/dev/Auto-GPT/autogpts/autogpt
configfile: pyproject.toml
plugins: anyio-4.0.0, integration-0.2.3, cov-4.1.0, asyncio-0.21.1, recording-0.13.0, mock-3.11.1, xdist-3.3.1, benchmark-4.0.0
asyncio: mode=Mode.STRICT
collected 0 items                                                                                                                                              

==================================================================== no tests ran in 0.11s =====================================================================
ERROR: found no collectors for /Users/swifty/dev/Auto-GPT/autogpts/autogpt/benchmark_config.json

@Swiftyos Swiftyos requested a review from a team September 11, 2023 15:30
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit e44fe44
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64ffb3f4c5082e00082e0a57
😎 Deploy Preview https://deploy-preview-5194--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Sep 11, 2023
@Swiftyos Swiftyos mentioned this pull request Sep 11, 2023
9 tasks
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Sep 12, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

@waynehamadi waynehamadi merged commit 9157268 into master Sep 12, 2023
7 of 9 checks passed
@waynehamadi waynehamadi deleted the benchmark/answers branch September 12, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants