New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement old polling mechanism #5248

Merged

waynehamadi merged 2 commits into master from fix-benchmark-being-stateful

Sep 18, 2023

Contributor

waynehamadi commented Sep 17, 2023

Background

Changes 🏗️

To save the reports in the correct folder, we use a class that is currently saved between API requests.
So by making it a singleton we're aware our application is stateful and
The other alternative was to pass the benchmark start time accross the app. But it blows up the scope.

PR Quality Scorecard ✨

Have you used the PR description template? +2 pts
Is your pull request atomic, focusing on a single change? +5 pts
Have you linked the GitHub issue(s) that this PR addresses? +5 pts
Have you documented your changes clearly and comprehensively? +5 pts
Have you changed or added a feature? -4 pts
- Have you added/updated corresponding documentation? +4 pts
- Have you added/updated corresponding integration tests? +5 pts
Have you changed the behavior of Auto-GPT? -5 pts
- Have you also run agbenchmark to verify that these changes do not regress performance? +10 pts

waynehamadi requested a review from a team

September 17, 2023 16:45

github-actions bot added the size/l label

netlify bot commented Sep 17, 2023

✅ Deploy Preview for auto-gpt-docs ready!

Name	Link
🔨 Latest commit	aa4277fe37dbfbf9805a9718a0d5600f94812204
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/65072d31dfc5fe0008692ff9
😎 Deploy Preview	https://deploy-preview-5248--auto-gpt-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2023 •

edited

Loading

✅ Deploy Preview for auto-gpt-docs ready!

Name	Link
🔨 Latest commit	`40a529c`
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/6508db329bdc620008fcc250
😎 Deploy Preview	https://deploy-preview-5248--auto-gpt-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

waynehamadi force-pushed the fix-benchmark-being-stateful branch 3 times, most recently from 548b746 to 1f2a6ec Compare

September 17, 2023 17:10

waynehamadi requested a review from a team as a code owner

September 17, 2023 17:10

waynehamadi force-pushed the fix-benchmark-being-stateful branch 4 times, most recently from b9658c3 to 0245d37 Compare

September 18, 2023 00:07

waynehamadi requested a review from Swiftyos as a code owner

September 18, 2023 00:07

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 0245d37 to ac1b633 Compare

September 18, 2023 00:11

github-advanced-security bot found potential problems

View reviewed changes

benchmark/agbenchmark/execute_sub_process.py

    
              def execute_subprocess(command, timeout):

                  process = subprocess.Popen(

                      command,

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a

user-provided value

.

waynehamadi force-pushed the fix-benchmark-being-stateful branch 6 times, most recently from 80c598b to 8cfbf48 Compare

September 18, 2023 03:58

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

github-actions bot added size/xl and removed size/l labels

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 8cfbf48 to db0aabd Compare

September 18, 2023 14:05

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from db0aabd to 6d0ad60 Compare

September 18, 2023 14:10

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 6d0ad60 to 30aa84c Compare

September 18, 2023 14:27

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 30aa84c to 9a8f3cb Compare

September 18, 2023 15:00

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 9a8f3cb to 91aab46 Compare

September 18, 2023 15:02

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 91aab46 to 89be23e Compare

September 18, 2023 15:10

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 89be23e to 760b943 Compare

September 18, 2023 15:13

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 760b943 to 0a7d026 Compare

September 18, 2023 15:13

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 0a7d026 to 0afcde3 Compare

September 18, 2023 19:57

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 0afcde3 to 5a658aa Compare

September 18, 2023 23:17

github-actions bot added size/l and removed size/xl labels


          Implement old polling mechanism

be7c3ca

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>

waynehamadi force-pushed the fix-benchmark-being-stateful branch from 5a658aa to be7c3ca Compare

September 18, 2023 23:17

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

github-actions bot added size/xl and removed size/l labels


          Merge branch 'master' into fix-benchmark-being-stateful

40a529c

Contributor

github-actions bot commented Sep 18, 2023

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

waynehamadi changed the title ~~Fix benchmark being stateful~~ Implement old polling mechanism

waynehamadi merged commit c09a0e7 into master

13 checks passed

waynehamadi deleted the fix-benchmark-being-stateful branch

September 18, 2023 23:23

waynehamadi added a commit that referenced this pull request


          Implement old polling mechanism (#5248)

fff2ce2

Implement old polling mechanism

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment