-
Notifications
You must be signed in to change notification settings - Fork 43.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up unified pre-commit + CI w/ linting + type checking & FIX EVERYTHING #7171
Merged
Pwuts
merged 79 commits into
master
from
reinier/open-1009-set-up-new-comprehensive-pre-commit-config
May 28, 2024
Merged
Set up unified pre-commit + CI w/ linting + type checking & FIX EVERYTHING #7171
Pwuts
merged 79 commits into
master
from
reinier/open-1009-set-up-new-comprehensive-pre-commit-config
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pwuts
requested review from
Torantulino and
majdyz
and removed request for
a team
May 25, 2024 22:01
✅ Deploy Preview for auto-gpt-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7171 +/- ##
==========================================
+ Coverage 36.05% 39.75% +3.70%
==========================================
Files 19 104 +85
Lines 1273 6756 +5483
Branches 182 1000 +818
==========================================
+ Hits 459 2686 +2227
- Misses 786 3962 +3176
- Partials 28 108 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pwuts
force-pushed
the
reinier/open-1009-set-up-new-comprehensive-pre-commit-config
branch
6 times, most recently
from
May 25, 2024 22:26
67b0543
to
5e910be
Compare
Pwuts
force-pushed
the
reinier/open-1009-set-up-new-comprehensive-pre-commit-config
branch
from
May 27, 2024 21:12
a68c010
to
1cce575
Compare
…own in db_test.py
Pwuts
force-pushed
the
reinier/open-1009-set-up-new-comprehensive-pre-commit-config
branch
from
May 28, 2024 00:06
5c13ee2
to
e2387a3
Compare
Pwuts
force-pushed
the
reinier/open-1009-set-up-new-comprehensive-pre-commit-config
branch
from
May 28, 2024 00:15
e2387a3
to
97867e1
Compare
Pwuts
changed the title
Set up unified pre-commit and CI linting
Set up unified pre-commit and CI linting / type checking & FIX EVERYTHING
May 28, 2024
Pwuts
changed the title
Set up unified pre-commit and CI linting / type checking & FIX EVERYTHING
Set up unified pre-commit + CI with linting + type checking & FIX EVERYTHING
May 28, 2024
Pwuts
changed the title
Set up unified pre-commit + CI with linting + type checking & FIX EVERYTHING
Set up unified pre-commit + CI w/ linting + type checking & FIX EVERYTHING
May 28, 2024
Pwuts
deleted the
reinier/open-1009-set-up-new-comprehensive-pre-commit-config
branch
May 28, 2024 03:04
Pwuts
added a commit
that referenced
this pull request
Jun 8, 2024
) Frontend broke in #7171 because of changes to the request models in `forge.agent_protocol`. This PR unbreaks it. Changes: - Make `input` required on `TaskRequestBody` and `StepRequestBody` - Amend `toJson()` on `TaskRequestBody` and `StepRequestBody` to omit attributes with `null` value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Changes
Linting
autogpt
,forge
, andbenchmark
Testing
autogpt
,forge
, andbenchmark
forge
test suiteAgentDB.close()
method for test DB teardown in db_test.pyforge
-code to from autogpt to forgeNotable type changes
Replace uses of
ChatModelProvider
byMultiProvider
Removed unnecessary exports from various init.py
Simplify
FileStorage.open_file
signature by removingIOBase
from return type unionS3BinaryIOWrapper(BinaryIO)
type interposer forS3FileStorage
Expand overloads of
GCSFileStorage.open_file
for improved typing of read and write modesHad to silence type checking for the extra overloads, because (I think) Pyright is reporting a false-positive:
reportIncompatibleMethodOverride
false positive on extra overloads in subclass microsoft/pyright#8007Change
count_tokens
,get_tokenizer
,count_message_tokens
methods onModelProvider
s from class methods to instance methodsMove
CompletionModelFunction.schema
method -> helper functionformat_function_def_for_openai
inforge.llm.providers.openai
Rename
ModelProvider
->BaseModelProvider
Rename
ChatModelProvider
->BaseChatModelProvider
Add type
ChatModelProvider
which is a union of all subclasses ofBaseChatModelProvider
Removed rather than fixed
forge.llm.providers.schema
andforge.models.providers
Fixes for other issues that came to light
Clean up
forge.agent_protocol.api_router
,forge.agent_protocol.database
, andforge.agent.agent
Add fallback behavior to
ImageGeneratorComponent
Fix
agbenchmark.challenges.builtin
challenge exclusion mechanism on WindowsFix
_tool_calls_compat_extract_calls
inforge.llm.providers.openai
Add support for
any
(= no type specified) inJSONSchema.typescript_type