feat(dx): add a code-workspace for vscode #7285
Conversation
codiumai-pr-agent-pro
bot
added
enhancement
|
PR Description updated to latest commit (8120b4e)
|
PR Reviewer Guide 🔍
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
PR Code Suggestions ✨
|
| }, | ||
| "extensions": { | ||
| "recommendations": [ | ||
| "charliermarsh.ruff", |
There was a problem hiding this comment.
Only one of the 5 projects in the repo currently uses Ruff.
There was a problem hiding this comment.
Each project uses diff things. Might as well suggest what we have
There was a problem hiding this comment.
Wouldn't this file cause Ruff to make all kinds of automatic changes, even in projects that don't use Ruff?
| "recommendations": [ | ||
| "charliermarsh.ruff", | ||
| "dart-code.flutter", | ||
| "ms-python.black-formatter", |
There was a problem hiding this comment.
Some use ruff some use black
| "ms-python.vscode-pylance", | ||
| "prisma.prisma", | ||
| "qwtel.sqlite-viewer", | ||
| "joshx.workspace-terminals" |
There was a problem hiding this comment.
VSCode already lets you choose when opening a terminal. If we have 10 folders by default I don't want it to open up 10 terminals on start-up, because there is no way I'll actually be working on all 10 folders at the same time.
There was a problem hiding this comment.
Oh lol there’s a setting to disable that
There was a problem hiding this comment.
Then what's the point of the extension? Afaics that's the only thing it does.
| "python.analysis.inlayHints.callArgumentNames": "partial", | ||
| "python.analysis.fixAll": [ | ||
| "source.convertImportFormat", | ||
| "source.unusedImports" |
There was a problem hiding this comment.
This one is actually quite annoying imo, because if you add an import with the intention of using it later and you hit save, the import disappears.
There was a problem hiding this comment.
Removing it is fine with me, just make the commits as I’m OOO for the next week or so. The workspace splitting and extension recommendations matter here more imo. Each project will probably have its own settings
Co-authored-by: Reinier van der Leer <pwuts@agpt.co>
| { | ||
| "name": ".github", | ||
| "path": "../.github" | ||
| }, | ||
| { | ||
| "name": ".vscode", | ||
| "path": "../.vscode" | ||
| }, | ||
| { | ||
| "name": "assets", | ||
| "path": "../assets" | ||
| }, |
There was a problem hiding this comment.
These don't need separate interpreters or environments so can be covered by the root folder
Co-authored-by: Reinier van der Leer <pwuts@agpt.co>
User description
Background
Developing autogpt is kinda a pain rn across all the different services. This allows you to have segmented terminals for each that don't try and activate weird poetry envs automatically
Changes 🏗️
PR Quality Scorecard ✨
+2 pts+5 pts+5 pts+5 pts-4 pts+4 pts+5 pts-5 ptsagbenchmarkto verify that these changes do not regress performance?+10 ptsPR Type
Enhancement, Configuration changes
Description
Changes walkthrough 📝
autogpt-workspace.code-workspace
Add VSCode workspace configuration for AutoGPT project.vscode/autogpt-workspace.code-workspace
workspace terminals.