Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroma memory #852

Closed
wants to merge 26 commits into from
Closed

Conversation

jhouseke
Copy link

@jhouseke jhouseke commented Apr 11, 2023

Background

Project needs more open source vector embedding db options.

Changes

Implemented Chroma database.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thouroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@jhouseke jhouseke closed this Apr 11, 2023
@jhouseke jhouseke reopened this Apr 11, 2023
@jhouseke jhouseke marked this pull request as ready for review April 11, 2023 20:50
scripts/config.py Outdated Show resolved Hide resolved
scripts/memory/chroma.py Outdated Show resolved Hide resolved
nponeccop
nponeccop previously approved these changes Apr 12, 2023
scripts/config.py Outdated Show resolved Hide resolved
@richbeales richbeales added the needs discussion To be discussed among maintainers label Apr 12, 2023
@nponeccop
Copy link
Contributor

@jhouseke There are conflicts now

@jhouseke
Copy link
Author

Resolved conflicts, thank you for heads up

@nponeccop
Copy link
Contributor

@jhouseke CI is red now.

@jhouseke
Copy link
Author

jhouseke commented Apr 17, 2023

removed whitespace to resolve W293

EDIT: resolving other issues identified, standby

EDIT_2: all issues identified in most recent CI run resolved

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 17, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@nponeccop nponeccop added the potential plugin This may fit better into our plugin system. label Apr 18, 2023
@HammadB
Copy link

HammadB commented Apr 24, 2023

Any progress on this - would love to use chroma with autogpt?

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 6:47pm

@jhouseke
Copy link
Author

Branch is up-to-date, awaiting merge

@vercel vercel bot temporarily deployed to Preview April 27, 2023 14:03 Inactive
@jhouseke
Copy link
Author

jhouseke commented May 2, 2023

@nponeccop any chance this can get merged in? thanks!

@vercel vercel bot temporarily deployed to Preview May 2, 2023 18:47 Inactive
@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@ntindle
Copy link
Member

ntindle commented May 25, 2023

Hey, I've marked this as don't merge until the Memory Fixes are in. Sorry to keep it on hold longer, just no real way to test/validate functionality until the fixes are in

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 25, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Pwuts Pwuts added function: memory + vector store Entails adding support for a vector store labels Jul 14, 2023
@Pwuts
Copy link
Member

Pwuts commented Sep 7, 2023

There is currently no prospect of this getting merged, so unfortunately I'll have to close it. The structure of the codebase and the application has changed a lot, so merging it would be a lot of work, and before we start adding vector stores, we need a good high-level design for memory use. This will be tracked in #3536, which needs updating as I write this.

There's a good chance Chroma will eventually be added, and we really do appreciate the effort that went into this PR. If you're still interested in (contributing to) the project, keep an eye on the #dev-autogpt channel. We've been making good progress in the past weeks, and my current #1 todo is making sure contributors can meaningfully contribute again.

@Pwuts Pwuts closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts function: memory needs discussion To be discussed among maintainers potential plugin This may fit better into our plugin system. size/l + vector store Entails adding support for a vector store
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

10 participants