Account for browser supported content types when sending files

Sija · Jan 12, 2024 · d1b9e9b · d1b9e9b
1 parent a613636
commit d1b9e9b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/ext/kemal.cr b/src/ext/kemal.cr
@@ -14,7 +14,9 @@ private def restore_headers_on_rescue(response, &)
   end
 end
 
-def send_file(env, file : GPhoto2::CameraFile, mime_type : String? = nil, disposition = "inline")
+private BROWSER_SAFE_EXTENSIONS = %w(.jpg .jpeg .png .gif .bmp .svg .webp)
+
+def send_file(env, file : GPhoto2::CameraFile, mime_type : String? = nil, disposition = nil)
   restore_headers_on_rescue(env.response) do |response|
     # WARNING: Executes extra calls to underlying camera
     if file.preview?
@@ -31,6 +33,9 @@ def send_file(env, file : GPhoto2::CameraFile, mime_type : String? = nil, dispos
       end
     end
 
+    ext = Path[filename].extension.downcase
+    disposition ||= "inline" if ext.in?(BROWSER_SAFE_EXTENSIONS)
+
     send_file env, file.to_slice,
       mime_type: mime_type,
       filename: filename,