Merge pull request #87 from Sija/develop

v1.9.2
Sija · Jun 14, 2022 · de91bb3 · de91bb3
2 parents d53319d + 4adc2a1
commit de91bb3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/shard.yml b/shard.yml
@@ -1,5 +1,5 @@
 name: raven
-version: 1.9.1
+version: 1.9.2
 
 authors:
   - Sijawusz Pur Rahnama <sija@sija.pl>
@@ -18,7 +18,7 @@ development_dependencies:
     version: ~> 0.4.0
   ameba:
     github: crystal-ameba/ameba
-    version: ~> 0.13.0
+    version: ~> 1.0.0
 
 targets:
   crash_handler:

diff --git a/spec/raven/breadcrumb_buffer_spec.cr b/spec/raven/breadcrumb_buffer_spec.cr
@@ -24,7 +24,7 @@ describe Raven::BreadcrumbBuffer do
 
   it "records breadcrumbs w/o block" do
     with_breadcrumb_buffer do |breadcrumbs|
-      crumb = Raven::Breadcrumb.new.tap { |b| b.message = "test" }
+      crumb = Raven::Breadcrumb.new.tap(&.message=("test"))
       breadcrumbs.record(crumb)
 
       breadcrumbs.members.first.should eq(crumb)
@@ -49,7 +49,7 @@ describe Raven::BreadcrumbBuffer do
     with_breadcrumb_buffer do |breadcrumbs|
       breadcrumbs.peek.should be_nil
 
-      crumb = Raven::Breadcrumb.new.tap { |b| b.message = "test" }
+      crumb = Raven::Breadcrumb.new.tap(&.message=("test"))
       breadcrumbs.record(crumb)
 
       breadcrumbs.peek.should eq(crumb)
@@ -65,7 +65,8 @@ describe Raven::BreadcrumbBuffer do
   it "evicts when buffer exceeded" do
     with_breadcrumb_buffer do |breadcrumbs|
       (0..30).each do |i|
-        breadcrumbs.record(Raven::Breadcrumb.new.tap { |b| b.message = i.to_s })
+        crumb = Raven::Breadcrumb.new.tap(&.message=(i.to_s))
+        breadcrumbs.record(crumb)
       end
 
       breadcrumbs.members.first.message.should eq("21")
@@ -77,15 +78,15 @@ describe Raven::BreadcrumbBuffer do
     with_breadcrumb_buffer do |breadcrumbs|
       breadcrumbs.peek.should be_nil
 
-      crumb = Raven::Breadcrumb.new.tap { |b| b.message = "test" }
+      crumb = Raven::Breadcrumb.new.tap(&.message=("test"))
       breadcrumbs.record(crumb)
 
       breadcrumbs.to_hash["values"].should eq([crumb.to_hash])
     end
   end
 
   it "clears in a threaded context" do
-    crumb = Raven::Breadcrumb.new.tap { |b| b.message = "test" }
+    crumb = Raven::Breadcrumb.new.tap(&.message=("test"))
     Raven::BreadcrumbBuffer.current.record(crumb)
 
     Raven::BreadcrumbBuffer.clear!

diff --git a/src/raven/client.cr b/src/raven/client.cr
@@ -99,14 +99,14 @@ module Raven
 
     private def generate_auth_header
       fields = {
-        sentry_version: PROTOCOL_VERSION,
-        sentry_client:  USER_AGENT,
-        sentry_key:     configuration.public_key,
+        :sentry_version => PROTOCOL_VERSION,
+        :sentry_client  => USER_AGENT,
+        :sentry_key     => configuration.public_key,
       }
       if secret_key = configuration.secret_key
-        fields = fields.merge(sentry_secret: secret_key)
+        fields[:sentry_secret] = secret_key
       end
-      "Sentry " + fields.map { |key, value| "#{key}=#{value}" }.join(", ")
+      "Sentry " + fields.join(", ") { |key, value| "#{key}=#{value}" }
     end
 
     private def get_message_from_exception(event)