Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bot replies to commands use the Discord reply feature - probably WITHOUT a true mention #37

Open
Silari opened this issue Apr 10, 2021 · 0 comments · May be fixed by #39
Open

Make bot replies to commands use the Discord reply feature - probably WITHOUT a true mention #37

Silari opened this issue Apr 10, 2021 · 0 comments · May be fixed by #39
Labels
enhancement New feature or request
Projects
Improvements

Comments

@Silari
Copy link
Owner

Silari commented Apr 10, 2021 •
edited

This was added in d.py 1.6.0. Might be nice to show what command the bot is responding to, in the unlikely event there are multiple commands being run in proximity.

For most command handlers this would be something like
channel.send(content=msg,embed=myembed, reference=message, mention_author=False

Or just
message.reply(content=msg, embed=myembed)
Not sure if that mentions or not.
@Silari Silari added the enhancement New feature or request label Apr 10, 2021
@Silari Silari added this to To do in Improvements via automation Apr 10, 2021
Silari pushed a commit that referenced this issue Apr 12, 2021
Handler responses for API contexts are now a reply to the message tha…
b6232ca 
…t initiated the request, unless the response may not be in the same channel (detail command is in the announcement channel regardless of where the command is performed).

Handler responses for built in contexts (except debug) are now a reply to the message the initiated the request, unless the response is not in the same channel or is in a DM.
Together, this resolves #37 unless further testing shows the command needs to be modified to prevent a mention ping.

Discord version updated to 1.7.1. No other changes were required to allow the new discord version.
@Silari Silari linked a pull request Apr 12, 2021 that will close this issue
Dpy 1.7 #39
Open
Silari pushed a commit that referenced this issue Apr 12, 2021
Resolves #37
7e1e3ab 
Bot replies will not trigger mentions.
@Silari Silari moved this from To do to In progress in Improvements May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Improvements
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dpy 1.7 Silari/DBContext
1 participant
@Silari