Display notification if app is locked #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #485
|
Haven't tested it but it looks good. Should do a quick update to fix this -
it's a pretty major breakage.
…On 5 December 2016 at 10:19, Bastien Le Querrec ***@***.***> wrote:
Display notification if app is locked
dc84d12
<dc84d12>
introduced a new way to manage notifications for encrypted messages, but it
results in no notifications when device is locked (because message is not
decrypted yet). This PR displays a notification when device is locked, even
if it is an encrypted message.
Fixes #485 <https://github.com/SilenceIM/Silence/issues/485>
------------------------------
You can view, comment on, or merge this pull request online at:
#486
Commit Summary
- display notification if app is locked
File Changes
- *M* src/org/smssecure/smssecure/jobs/SmsReceiveJob.java
<https://github.com/SilenceIM/Silence/pull/486/files#diff-0> (10)
Patch Links:
- https://github.com/SilenceIM/Silence/pull/486.patch
- https://github.com/SilenceIM/Silence/pull/486.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#486>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcf_fbmhTXo6ZEiexIjw6wYCf_H50jDks5rFCuLgaJpZM4LEWLS>
.
|
|
There is still a minor glitch when app is unlocked. I will fix it, then merge, then release v0.14.6. |
|
I will wait for the update to validate |
|
For me, it works. Notification, Sound message, vibration and led blinking For unencrypted conversations and Silence Locked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display notification if app is locked
dc84d12 introduced a new way to manage notifications for encrypted messages, but it results in no notifications when device is locked (because message is not decrypted yet). This PR displays a notification when device is locked, even if it is an encrypted message.
Fixes #485