version 1.2.0 -- negative number fix

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.2.0 -- decimal number fix
+
+1. now throws under decimal number
+
 # 1.1.0 -- es5 support
 
 1. es5 support

package.json

@@ -1,6 +1,6 @@
 {
   "name": "number-to-bn",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "A simple method that will convert a string integer, hex, BN or bignumber.js object into a BN.js object.",
   "main": "src/index.js",
   "scripts": {

src/index.js

@@ -22,7 +22,7 @@ module.exports = function numberToBN(arg) {
     } else {
       throw errorMessage;
     }
-  } else if (typeof arg === 'number') {
+  } else if (typeof arg === 'number' && String(arg).match(/^-?[0-9]+$/)) {
     return new BN(String(arg));
   } else if (typeof arg === 'object'
     && arg.toString

src/tests/test.index.js

@@ -15,6 +15,10 @@ describe("numberToBN", () => {
       assert.deepEqual(numberToBN(new BigNumber(1000)).toNumber(10), 1000);
     });
 
+    it('should convert a negative 1.1 throws', () => {
+      assert.throws(() => numberToBN(1.1).toNumber(10), Error);
+    });
+
     it('should convert a negative BigNumber', () => {
       assert.deepEqual(numberToBN(new BigNumber(-1)).toNumber(10), -1);
     });