Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull rocket from simulation, not simulation options #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoePfeiffer
Copy link

OR version 22.02 has moved the getRocket() method from simulation options to the simulation itself. This updates the Monte Carlo example to this version.

@SilentSys
Copy link
Owner

Thanks for this! I didn't realize a new version of OR was released. I'm currently busy but I'll have some time to look into it in a few weeks.

@christophfroehlich
Copy link

christophfroehlich commented Aug 23, 2023

Are there any updates on this?
Apart from this change, is orhelper compatible to OR 22? It seems that they updated to Java 11.

I guess this has to be updated, too.

CLASSPATH = os.environ.get("CLASSPATH", "OpenRocket-15.03.jar")

@JoePfeiffer
Copy link
Author

JoePfeiffer commented Aug 23, 2023

Are there any updates on this? Apart from this change, is orhelper compatible to OR 22? It seems that they updated to Java 11.

I guess this has to be updated, too.

CLASSPATH = os.environ.get("CLASSPATH", "OpenRocket-15.03.jar")

Yes, with the change in the PR I've been using it successfully with 22.02. I'd forgotten the necessary change to the default classpath, since I very rarely run it from the directory containing the jar file so I need to set the environment variable correctly anyway.

Copy link

@Softchair Softchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these on my machine and they seem to work good

@SiboVG
Copy link

SiboVG commented Feb 5, 2024

@SilentSys care to merge this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants