Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend documentation to document any relevant classes. #5

Merged

Conversation

Shugabuga
Copy link
Collaborator

This pull request documents nearly everything that was provided in the
pseudocode sample Sileo Team sent me a few weeks back.

(Note: As I want my PR-ing practices to be as straightforward as
possible, any separate piece of documentation will have its own pull
request.)

The only view I didn’t document intentionally was
DepictionMinVersionForceView because it only affects Sileo version.
Its use is an edge case, as far as I know. I may change my mind later
as native depictions become even more complex. That, and
backgroundColor, because I don’t see a good use for that.

I also corrected a few mistakes from #3 that I discovered when working on my own repo.

This commit documents nearly everything that was provided in the
pseudocode sample you sent me a few weeks back.

(Note: As I want my PR-ing practices to be as straightforward as
possible, any separate piece of documentation will have its own pull
request.)

The only view I didn’t document intentionally was
`DepictionMinVersionForceView` because it only affects Sileo version.
Its use is an edge case, as far as I know. I may change my mind later
as native depictions become even more complex. That, and
`backgroundColor`, because I don’t see a *good* use for that.
I may change this later.
@coolstar coolstar merged commit 1cc9b56 into Sileo:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants