[pull] main from openthread:main #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This commit simplifies the border router tests by replacing self.nodes[<NODE_ID>] with shorter names.
This commit replaces the `enum` constants with `constexpr` definitions in all the modules under `core/net`. This commit also contains some smaller changes: typo fixes in the comments, removal of unused constants, and adding `uint` type to the named `enum` definitions.
This commit enhances the template `Array` class implementation to allow the `uint` type used for array size (which is also used for length and index) to be specified as a template type parameter. If not explicitly specified, a default `uint` type is selected based on the array size `kMaxSize`, i.e., if `kMaxSize <= 255` then `uint8_t` will be used, otherwise `uint16_t` will be used.
This commit adds template `Find/ContainsMatching<Indicator>()` methods which search in the array to find the first element matching a given indicator. Unit test `test_array` is also updated to check the behavior of newly added methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 馃挅 Please sponsor : )