SiW917 SOC bring up with new Wi-Fi SDK support #123
Conversation
shgutte
requested review from
jepenven-silabs,
jmartinez-silabs,
mkardous-silabs and
selissia
as code owners
| @@ -0,0 +1,32 @@ | |||
| // This file is autogenerated by Silicon Labs SLC. | |||
There was a problem hiding this comment.
Please specify which version of GSDK these files were taken from. Does the content of the rest of the files in this part of the repo correspond to that GSDK version? In other words, after this PR will the content match some version of GSDK?
There was a problem hiding this comment.
we are using the files from GSDK 4.2.0 all the files we took from that GSDK only
There was a problem hiding this comment.
How will it work when we update to GSDK 4.3.1 ?
There was a problem hiding this comment.
We tested with GSDK 4.3.0 it's working
There was a problem hiding this comment.
nvm3 contents are copied from gecko_sdk (4.2.0) and it's customized for 917 SoC in matter_support.
We are planning to remove the nvm3 from matter_support and use it from gecko_sdk. But, we need some changes from wiseconnect sdk 3.0 for this support (common and dual flash driver support for nvm3).
We will create new PR for matter_support after new modifications are tested with latest wiseconnect sdk 3.0 .
It will be good if this PR is approved for testing the SoC apps in studio.
* Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
| @@ -0,0 +1,32 @@ | |||
| // This file is autogenerated by Silicon Labs SLC. | |||
There was a problem hiding this comment.
How will it work when we update to GSDK 4.3.1 ?
|
|
||
| #ifndef NVM3_DEFAULT_REPACK_HEADROOM | ||
| // <o NVM3_DEFAULT_REPACK_HEADROOM> NVM3 Default Instance User Repack Headroom | ||
| // <i> Headroom determining how many bytes below the forced repack limit the |
There was a problem hiding this comment.
Theses files should not be here IMO
| * @brief Core interrupt handling API | ||
| ******************************************************************************* | ||
| * # License | ||
| * <b>Copyright 2018 Silicon Laboratories Inc. www.silabs.com</b> |
There was a problem hiding this comment.
Why is a .bak file here ?
| @@ -16,7 +16,7 @@ | |||
| ******************************************************************************/ | |||
| #include "ccp_flash_intf.h" | |||
| #include "RS1xxxx_9117.h" | |||
| #include "rsi_board.h" | |||
| //#include "rsi_board.h" | |||
There was a problem hiding this comment.
Why are these lines commented out ? If they are not needed they should be removed..
| @@ -0,0 +1,69 @@ | |||
| /***************************************************************************/ /** | |||
| * @file | |||
| ****************************** MACROS ********************************** | ||
| *****************************************************************************/ | ||
|
|
||
| #define CHECK_DATA 1 ///< Macro defining if data should be checked |
There was a problem hiding this comment.
Pretty sure theses files are copy pasted from the GSDK.... Why ?
There was a problem hiding this comment.
The whole file and the whole directory tree under platform/ is copied from the GSDK
|
Is this still being worked on? Can it be closed? Why is the platform folder copy-pasted from the GSDK? |
|
@shgutte ^ can we close? |
Problem / Feature:
SiW917 SOC facing some build issues because of nvm files and other files.
Change overview
SiW917 SOC brings up new Wi-Fi SDK support needs this nvm changes
Testing
SiW917 SOC