Skip to content
This repository has been archived by the owner on Aug 22, 2018. It is now read-only.

[Visual Studio Extensions] Default syntax highlight colors #26

Closed
dfkeenan opened this issue Sep 27, 2014 · 11 comments
Closed

[Visual Studio Extensions] Default syntax highlight colors #26

dfkeenan opened this issue Sep 27, 2014 · 11 comments
Assignees
Milestone

Comments

@dfkeenan
Copy link

Hi,

Could you please improve the default syntax highlight colors for the various VS themes. The shaders and YAML files currently are a bit hard on the eyes when using the dark theme.

Cheers,
dfkeenan

@gitfool
Copy link

gitfool commented Sep 28, 2014

I would say they're nearly unreadable when using the dark theme. I mapped colours to their C# equivalent where possible, which would be a nicer default.

@xen2 xen2 self-assigned this Sep 29, 2014
@xen2 xen2 added this to the beta02 milestone Oct 21, 2014
@xen2 xen2 added the fixed label Oct 21, 2014
@xen2
Copy link
Contributor

xen2 commented Oct 22, 2014

Fixed in newly released beta02.

@xen2 xen2 closed this as completed Oct 22, 2014
@gitfool
Copy link

gitfool commented Oct 23, 2014

After installing beta02 I reset to Use Defaults for the Environment Fonts and Colors settings for Text Editor. Most the colors are okay except:

  • Paradox Shader Language - Identifier
  • Paradox Shader Language - Intrinsic
  • Paradox Shader Language - Keyword
  • Paradox Shader Language - Number

Intrinsic is actually readable but slightly too dark. The others are still way too dark and / or the contrast is wrong for the dark theme. I suppose it could be my monitor settings, but it might be worth double checking the color settings.

@dfkeenan
Copy link
Author

Yeah still looks pretty bad to me :(

@xen2
Copy link
Contributor

xen2 commented Oct 23, 2014

image

Does it match what you see?
I just took same colors I had on my C# code (I have resharper installed, maybe it has different colors than stock).

@xen2 xen2 reopened this Oct 23, 2014
@gitfool
Copy link

gitfool commented Oct 23, 2014

No. It looks like this:
image

@xen2
Copy link
Contributor

xen2 commented Oct 23, 2014

If colors were already set by previous plugin, it won't touch them (because it doesn't know if it wasn't manually changed by user).
What triggers a change is:

  • First run will automatically create proper colors
  • Going back and forth to light and dark theme

Could you try setting light and then dark theme again?

@gitfool
Copy link

gitfool commented Oct 23, 2014

Bingo!
image

@xen2
Copy link
Contributor

xen2 commented Oct 23, 2014

Ok good! :)

@xen2 xen2 closed this as completed Oct 23, 2014
@dfkeenan
Copy link
Author

Yep that fixed it. Thanks for the quick response @xen2

@discosultan
Copy link

What's weird is that whenever I press Use Defaults in the Fonts and Colors dialog, the syntax highlight colors for .xksl files will be reverted back to this: syntax highlight colors

stride-bot pushed a commit that referenced this issue Jan 16, 2017
* commit 'd377dae392d7a37e813cb36d67c9ce6795421721':
  [Presentation] Rework initialization of the ScrollViewer in the TreeView
  [Presentation] Add some documentation to the TreeView control
  [Presentation] Document and move CheckTemplatePart to DependencyObjectExtensions.
  [Presentation] Prevent the TreeView to change scroll position if layout is updated between mouse down and mouse up (fix XK-3953)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants