Alignas on posix failing under Gcc 8.3.0 #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alignas is a keyword in c++. Dont define. Change is in windows header already, and GCC 8.3.0 is erroring on this now.
|
@fuzzard thanks for this. I've tested this PR with gcc-8.2.0 and gcc-8.3.0 and both are now building the PVR HD Homerun add-on successfully. We'll include this PR in LibreELEC until it merges (which could be a while) as it's likely to affect gcc-9.0.0 in turn, which should be released in April. |
|
fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alignas is a keyword in c++. Dont define.
Change is in windows header already, and GCC 8.3.0 is erroring on this now.
hd_homerun_windows_os.h already handles the definition this way.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89464