Update nokogiri and uri #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokogiri was updated to 1.12 to match what we have in production and ox was updated to ohler55/master since Tim's original patch in branch add-raw was eventually merged there (see ohler55/ox#117).
URI delegates these calls to the DEFAULT_PARSER which has not been removed, and is likely to remain, so we can continue to use it for the time being.
This updates the Mongo API and fixes specs to get a green test suite. However the MongoResource model is not production-ready as it has been currently designed. It does not take advantage of chunks in the GridFS to load file ranges and all file operations load the entire file into memory.
|
This PR is ready for review now. Further to the fixes in my previous comment, I have also made the test suite green. This should help should we need to make further changes later. Also note, as I mentioned in the commit message, the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails 6.1.4.1comes withnokogiri 1.12.3thus requiring an update here. This change brakes one old behaviour: when a namespace is not explicitly specified, rendering no longer searches for a namespace on the ancestors tree (see sparklemotion/nokogiri@1f483f0 and https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md#fixed-4). To keep the old behaviour we now have to explicitly set the namespace for inner nodes when using the XML builder.While at this, I have also removed the obsolete
URI.escapeandURI.unescapecalls. Since the underlying parser used for these calls is still available viaURI::DEFAULT_PARSERI have continued to use uri library for the time begin.Also note that I updated
oxto ohler55/master since Tim's original patch in branch add-raw was eventually merged there (see ohler55/ox#117).Lastly, some specs are just broken before this change. I tried to wrangle with them for a little while to no avail. We'll properly test this upstream.