New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #12713: New transversal basket and Newsletter improvements #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into account some improvements in the business code. Resolve issues detected by sonar.
Take into account the merge between ApplicationService and ContributionManager, and the deletion of ContributionManager.
Implementing the manager ables to provide an info letter contribution from a contribution identifier. Registering the wysiwyg editor configuration of InfoLetter components. Implementing the generic API around Contribution in order to handle from a centralize way the InfoLetter data and UI accesses. Drag and Drop Editor UI wiring.
For publications in Kmelia: because the draftOutDate is always set at null and because the automatic drafting out process (batch process) isn't more used (anyway it cannot work because the draftOutDate is always null) since 2011, the process and the draftOutDate attribute and its handling in the code are all removed of the code. Add the basket use in Kmelia.
KmeliaPublication is now an I18nContribution and supports both WithPermaLink and WithTumbnail features. Fix in javascript a bug when removing the unselected publications from the selection basket. Delete unused code in KmeliaSessionController Add support of ApplicationService to Toolbox app. Now the publications of a toolbox app can be put in the selection basket.
Add support of the selection basket to QuickInfo. Take into account when a publication or a news is in draft when viewing it.
The calendar events can be put now in the selection basket. Improve codes according to SonarCube issues.
Moving the home page to the new rendering designed by Aurore. Making the impacted JSP as full JSTL implemented. Using from Gallery component centralized stuffs around WYSIWYG APIs. Fixing on publication.js some execution problems with IE. Using also new possibilities of basket services. Fixing sonar feedback.
Adding the possibility to send to itself the template. Using the transversal mail sending management. Adding the sending of a letter to itself. Making that a publisher can not manage a template. Adding a parameter to set the N last newsletter for users on application instance homepage. Removing the action 'Registering as Template' which is now obsolete. Refactoring the newletter portlets... Adding the possibility to select as fast as possible elements for basket selection container (GED, News and Calendar events).
This was referenced Mar 1, 2022
Merged
Merged
Merged
Kudos, SonarCloud Quality Gate passed! |
SilverYoCha
commented
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to PRs: