Feature #13789: improving performances into blog loading data. #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverYoCha
force-pushed
the
feature-13789
branch
2 times, most recently
from
648cf78
to
672da05
Compare
mmoqui
requested changes
Jan 22, 2024
There was a problem hiding this comment.
I ask for renaming some original method names. It is for a better understanding for both new developers and for those who get back to the code months or years later. We have to establish a clear distinction between a blog post and an event that can be related by such a post; a post isn't an event, it creates an event (in the calendar of the blog): either the event about which its content is or the event of the post writing itself.
blog/blog-library/src/main/java/org/silverpeas/components/blog/dao/PostDAO.java
Outdated
Show resolved
Hide resolved
blog/blog-library/src/main/java/org/silverpeas/components/blog/dao/PostDAO.java
Outdated
Show resolved
Hide resolved
blog/blog-library/src/main/java/org/silverpeas/components/blog/service/BlogFilters.java
Outdated
Show resolved
Hide resolved
blog/blog-library/src/main/java/org/silverpeas/components/blog/service/BlogService.java
Outdated
Show resolved
Hide resolved
blog/blog-library/src/main/java/org/silverpeas/components/blog/service/DefaultBlogService.java
Outdated
Show resolved
Hide resolved
blog/blog-library/src/main/java/org/silverpeas/components/blog/service/DefaultBlogService.java
Outdated
Show resolved
Hide resolved
SilverYoCha
force-pushed
the
feature-13789
branch
from
672da05
to
32f198a
Compare
|
mmoqui
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to PR Silverpeas/Silverpeas-Core#1319