Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails on OSX #32

Closed
ktbolt opened this issue Jan 12, 2019 · 2 comments
Closed

Compilation fails on OSX #32

ktbolt opened this issue Jan 12, 2019 · 2 comments
Assignees
Labels

Comments

@ktbolt
Copy link
Contributor

ktbolt commented Jan 12, 2019

I tried to build on a Mac but compilation failed with the following error

svSolver/Code/ThirdParty/nspcg/simvascular_nspcg/nspcg4.f:687:24:

   call pfs (n,b1,b2,x)
                    1

Error: Actual argument contains too few elements for dummy argument 'x' (1/2) at (1)

@ktbolt ktbolt self-assigned this Jan 12, 2019
@ktbolt ktbolt added the bug label Jan 12, 2019
@ktbolt
Copy link
Contributor Author

ktbolt commented Jan 12, 2019

The compilation error is caused by the latest gfortran 8.1 release which is part of gcc 8.1.

When an actual argument contains too few elements for a dummy argument, an error is now issued. The -std=legacy option can be used to still compile such code.

I added this option to the CMAKE_Fortran_FLAGS varaible in the svSolver/Code/CMake/SimVascularOptions.cmake file and everything now compiles.

@ktbolt
Copy link
Contributor Author

ktbolt commented Jan 22, 2019

This has been merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant