This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
Clearer jsdomError messages #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the missing response @haroldhues! I had over 3k notification on GH and I'm currently trying to wade through them 😅 Could you send this PR to Jest core? The logic here is copied from there https://github.com/facebook/jest/blob/2b748f67c25615a111330017a2bffc0baf51d558/packages/jest-environment-jsdom/src/index.ts#L38 |
|
But yes, sending a PR with this to Jest core would be appreciated 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a situation where I was creating a 'jsdomError'. Jest reported the error like so:
At first glance it is easy to miss that the
error.detailis concatenated to the end of the fourth line, I certainly missed it.I found that happened because by default jsdom logs the error.stack and error.default as two parameters to console.error
This PR overrides that default and lets jest format the errors, which it does very nicely: