Skip to content

Commit

Permalink
cleanup comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tooppaaa committed Jul 5, 2020
1 parent 86e487a commit fb7718d
Showing 1 changed file with 2 additions and 11 deletions.
13 changes: 2 additions & 11 deletions lib/cli/src/generators/baseGenerator.ts
Expand Up @@ -46,25 +46,16 @@ export async function baseGenerator(
const addons = [
'@storybook/addon-links',
'@storybook/addon-actions',
// If angular skip `docs` because docs is buggy for now (https://github.com/storybookjs/storybook/issues/9103)
// for others framework add `essentials` i.e. `actions`, `backgrounds`, `docs`, `viewport`
// API of essentials needs to be clarified whether we need to add dependencies or not
'@storybook/addon-essentials',
].filter(Boolean);

// 鈿狅笍 Some addons have peer deps that must be added too, like '@storybook/addon-docs' => 'react-is'
const addonsPeerDeps = addons.some(
(addon) => addon === '@storybook/addon-essentials' || addon === '@storybook/addon-docs'
)
? ['react-is']
: [];

const packages = [
`@storybook/${framework}`,
...addons,
...extraPackages,
...extraAddons,
...addonsPeerDeps,
// 鈿狅笍 Some addons have peer deps that must be added too, like '@storybook/addon-docs' => 'react-is'
'react-is',
].filter(Boolean);
const versionedPackages = await packageManager.getVersionedPackages(...packages);

Expand Down

0 comments on commit fb7718d

Please sign in to comment.