Skip to content

Commit

Permalink
Xcode 10.2: update localization configuration for 0 files
Browse files Browse the repository at this point in the history
opening this project in Xcode 10.2 results in issue navigator
diagnostics:
- a warning diagnostic that the project needs to be migrated
  w.r.t. the deprecated usage of "developmentRegion = English"
- another diagnostic w.r.t. the use of Base localization

however, there are 0 localized files in the project, so it is
actually possible to remove the localized "known region" (as
seen in the XML diff) to contain no regions.

Xcode 10.2.1 does suggest enabling the warning
"CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES"
in order to capture any cases of broken usage
(of which there are none currently).
  • Loading branch information
Kirk Beitz committed May 4, 2019
1 parent 0dd3d5a commit 3e79f09
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions PhoneNumberKit.xcodeproj/project.pbxproj
Expand Up @@ -396,10 +396,9 @@
};
buildConfigurationList = 3424185E1BB6E5A000EE70E7 /* Build configuration list for PBXProject "PhoneNumberKit" */;
compatibilityVersion = "Xcode 8.0";
developmentRegion = English;
developmentRegion = en;
hasScannedForEncodings = 0;
knownRegions = (
en,
);
mainGroup = 3424185A1BB6E5A000EE70E7;
productRefGroup = 342418651BB6E5A000EE70E7 /* Products */;
Expand Down Expand Up @@ -559,6 +558,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
Expand Down Expand Up @@ -620,6 +620,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
Expand Down

0 comments on commit 3e79f09

Please sign in to comment.