Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Theme Application #149

Merged
merged 1 commit into from Oct 4, 2023
Merged

🐛 Fix Theme Application #149

merged 1 commit into from Oct 4, 2023

Conversation

aditya-css
Copy link
Collaborator

  • Fixes issue 136.
  • Removed cursorColor, textColor, and themeColor from CreditCardForm.
  • Removed Theme from CreditCardForm as to allow theme of the user application to be applied.

CHANGELOG.md Outdated
@@ -8,6 +8,9 @@
- Added dart 3 support [#146](https://github.com/SimformSolutionsPvtLtd/flutter_credit_card/pull/146).
- Fixed package structure and improved code overall [#150](https://github.com/SimformSolutionsPvtLtd/flutter_credit_card/pull/150).
- Fixed and improved card type detection logic [#151](https://github.com/SimformSolutionsPvtLtd/flutter_credit_card/pull/151).
- Fixed [#136](https://github.com/SimformSolutionsPvtLtd/flutter_credit_card/issues/136)
Application theme not applied to `CreditCardForm`. Removed `themeColor`, `textColor`,
`cursorColor` from `CreditCardForm`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention alternate solution of removed properties

Copy link
Collaborator

@manoj-simform manoj-simform left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment added

@vatsaltanna vatsaltanna merged commit 7111fa2 into master Oct 4, 2023
1 check passed
@vatsaltanna vatsaltanna deleted the bugfix/theme_fix branch October 4, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theming not working
3 participants