The cards expired date validation control bug fixed. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expiry date on the cards should be based on the last day of that month. Since the current structure is based only on the month, it does not work correctly. As a bug fix, the last day of the month was found and added to the card expiry date.
ocakliemre
changed the title
|
@ocakliemre This branch is having conflicts with the latest release, can you please take upstream of the latest changes, fix the conflict and update the PR so we can review it? |
|
@ocakliemre just a reminder for resolving conflicts of this branch with the latest release, can you please update this PR so we can review it? |
Updated repo with latest master
kavantrivedi
reviewed
Sep 8, 2022
lib/credit_card_form.dart
Outdated
| @@ -247,7 +248,8 @@ class _CreditCardFormState extends State<CreditCardForm> { | |||
| final List<String> date = value.split(RegExp(r'/')); | |||
| final int month = int.parse(date.first); | |||
| final int year = int.parse('20${date.last}'); | |||
| final DateTime cardDate = DateTime(year, month); | |||
| final int lastDayofMonth = DateTime(year, Jiffy( DateTime(year,month)).add(months: 1).month, 0 ).day; | |||
There was a problem hiding this comment.
@ocakliemre can we use another way to get the last date of the month, as we do not want any additional package dependencies?
kavantrivedi
approved these changes
Sep 8, 2022
shwetachauhan-simform
suggested changes
Sep 9, 2022
example/lib/main.dart
Outdated
| @@ -190,8 +190,7 @@ class MySampleState extends State<MySample> { | |||
| style: ElevatedButton.styleFrom( | |||
| shape: RoundedRectangleBorder( | |||
| borderRadius: BorderRadius.circular(8.0), | |||
| ), | |||
| primary: const Color(0xff1b447b), | |||
| ), backgroundColor: const Color(0xff1b447b), | |||
There was a problem hiding this comment.
same here, formatting issue
|
Hey @ocakliemre, |
ocakliemre
force-pushed
the
expired-date-validation-bug-fix
branch
from
24ca037
to
52c1cf3
Compare
|
@ocakliemre : You can squash all commit |
ShwetaChauhan18
approved these changes
Sep 9, 2022
lib/credit_card_form.dart
Outdated
| @@ -247,7 +245,8 @@ class _CreditCardFormState extends State<CreditCardForm> { | |||
| final List<String> date = value.split(RegExp(r'/')); | |||
| final int month = int.parse(date.first); | |||
| final int year = int.parse('20${date.last}'); | |||
| final DateTime cardDate = DateTime(year, month); | |||
| final int lastDayOfMonth = month < 12 ? DateTime(year, month + 1, 0).day : DateTime(year + 1, 1, 0).day; | |||
| final DateTime cardDate = DateTime(year, month, lastDayOfMonth,23,59,59,999); | |||
ShwetaChauhan18
approved these changes
Sep 9, 2022
shwetachauhan-simform
approved these changes
Sep 9, 2022
shwetachauhan-simform
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expiry date on the cards should be based on the last day of that month. Since the current structure is based only on the month, it does validation not work correctly. As a bug fix, the last day of the month was found and added to the card expiry date.