Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Ignore extra _nextIfAny function operations as showcase maybe discarded at the time of next call #410

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Sahil-Simform
Copy link
Collaborator

  • Added isShowCaseCompleted getter to check the showcase is completed or not
  • If the showcase is already completed no need to further process the _nextIfAny function operations and we will stop execution of this function. This may happen if a user taps very fast and lots of time on the showcase barrier

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #389

…e discarded at time of next call

- Added `isShowCaseCompleted` getter to check the showcase is completed or not
- If the showcase is already completed no need to further process the `_nextIfAny` function operations and we will stop execution of this function. This may happen if a user taps very fast and lots of time on the showcase barrier
@aditya-css aditya-css merged commit 189a760 into master Mar 8, 2024
2 checks passed
@aditya-css aditya-css deleted the bugFix/issue_389_fix branch March 8, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffold.geometryOf() must only be accessed during the paint phase. V^2.0.2
2 participants