Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fixed RecalculateRootWidgetSize null check issue. #429

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

aditya-css
Copy link
Collaborator

Description

  • Added mounted check in addPostFrameCallback under recalculateRootWidgetSize in showcase.dart as to ensure that the operation is only performed if the element is mounted.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #428

- Added `mounted` check in `addPostFrameCallback` under `recalculateRootWidgetSize` in `showcase.dart` as to ensure that the operation is only performed if the element is mounted.
@aditya-css aditya-css merged commit 49fa2e1 into master Apr 29, 2024
2 checks passed
@aditya-css aditya-css deleted the fix/issue_428 branch April 29, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_ShowcaseState.recalculateRootWidgetSize null value
2 participants