feat: UNT-T24855: added candleHeightScale and onCurrentProgressChange #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nilesh-simform
commented
May 3, 2024
nilesh-simform
commented
- Added candleHeightScale prop to handle scaling the waveform candles
- Added onCurrentProgressChange to get the progress and song duration of currently played audio
kuldip-simform
requested changes
May 3, 2024
nilesh-simform
force-pushed
the
feature/UNT-T24855_candle_height_and_current_progress_props
branch
from
f78789c
to
9728680
Compare
nilesh-simform
force-pushed
the
feature/UNT-T24855_candle_height_and_current_progress_props
branch
from
9728680
to
fb7279f
Compare
kuldip-simform
approved these changes
May 3, 2024
mukesh-simform
approved these changes
May 8, 2024
mukesh-simform
deleted the
feature/UNT-T24855_candle_height_and_current_progress_props
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.