Fix issue with mutations running in the wrong order when triggered by…

… third party libs
SimoTod · Nov 15, 2021 · c3e2f58 · c3e2f58
1 parent aa7167b
commit c3e2f58
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/packages/alpinejs/src/lifecycle.js b/packages/alpinejs/src/lifecycle.js
@@ -14,7 +14,7 @@ export function start() {
     startObservingMutations()
 
     onElAdded(el => initTree(el, walk))
-    onElRemoved(el => nextTick(() => destroyTree(el)))
+    onElRemoved(el => destroyTree(el))
 
     onAttributesAdded((el, attrs) => {
         directives(el, attrs).forEach(handle => handle())

diff --git a/packages/alpinejs/src/mutation.js b/packages/alpinejs/src/mutation.js
@@ -160,14 +160,6 @@ function onMutate(mutations) {
         onAttributeAddeds.forEach(i => i(el, attrs))
     })
 
-    for (let node of addedNodes) {
-       // If an element gets moved on a page, it's registered
-        // as both an "add" and "remove", so we want to skip those.
-        if (removedNodes.includes(node)) continue
-
-        onElAddeds.forEach(i => i(node))
-    }
-
     for (let node of removedNodes) {
         // If an element gets moved on a page, it's registered
         // as both an "add" and "remove", so we want to skip those.
@@ -176,6 +168,14 @@ function onMutate(mutations) {
         onElRemoveds.forEach(i => i(node))
     }
 
+    for (let node of addedNodes) {
+       // If an element gets moved on a page, it's registered
+        // as both an "add" and "remove", so we want to skip those.
+        if (removedNodes.includes(node)) continue
+
+        onElAddeds.forEach(i => i(node))
+    }
+
     addedNodes = null
     removedNodes = null
     addedAttributes = null