Feature: Replace followed threads links with my posts link

[LemonIllusion]

No description provided.

[LemonIllusion]

The operation fails and an error is logged if user is not logged in. Is it possible to implement isLoggedIn in a reasonable way or should the error just be caught and suppressed?

[SimonAlling]

Nice feature! I would like to request some changes:

• The icon doesn't really fit in to me due to its white part, and it usually means "unread". What do you think about the one with two stacked papers (-250px -100px) instead?
• I think italics would look nicer than quotation marks in the preference label – i.e. `Ersätt knappen <em>Följda trådar</em> med <em>Mina inlägg</em>`. It also lends itself better to styling.
• Rename REPLACE_FOLLOWED_BUTTON to REPLACE_FOLLOWED_THREADS_LINK in operations.ts.
• Rename the operation file correspondingly to replace-followed-threads-link.ts.
• followed threads link instead of followed threads button in the operation description.
• textContent instead of innerHTML in the operation.
• SITE.CLASS.hasUnread (and create it) instead of "hasUnread" in the operation.
• replace_followed_threads_link instead of replace_followed_button in the preference (and wherever it is used).
• Rename the SASS file to replace-followed-threads-link.scss.

Also, due to the commit message limit of 50 characters that I use and in accordance with my requested changes of nomenclature, I suggest this message instead:

Replace followed threads link with my posts link

[SimonAlling]

Regarding isLoggedIn: The other detectors in the environment module depend only on data available at document-start, namely document.location.pathname. For isLoggedIn to make sense, I think it should be implemented in the same way, i.e. not by looking at any page content.

And I hereby proudly present a solution:

export function isLoggedIn(): boolean {
    return (document.head.textContent as string).includes(`'visitorType': 'member'`);
}

I have pushed the implementation above, so you should be able to use it if you pull that commit (d286580).

[LemonIllusion]

I think I've gitted far beyond my proper understanding, but that should be every change you requested and then some. Anything more to do?

[SimonAlling]

I found three more things I would like to change. Two of them I should have seen the first time, but here goes:

• The preference label should say länken instead of knappen.
• The preference should be moved up so it sits between insert_preferences_shortcut and insert_web_search_button. The reason is that insert_web_search_button and search_engine should be adjacent to each other. Note that this needs to be changed in the text module as well, for consistency.
• In the operation, HTMLLinkElement is actually not correct; it should be HTMLAnchorElement. Classic mistake that I've made a couple of times myself. :)

I think you can simply make these changes in a new commit; I'll squash all the commits in this feature branch into a single one anyway.

[LemonIllusion]

Do you like the idea of using ${general.my_posts} instead of writing out Mina inlägg in the setting label? It's less repetition, but would force a specific ordering of the text groups and possibly cause issues with circular dependencies if encouraged.

[SimonAlling]

Do you like the idea of using ${general.my_posts} instead of writing out Mina inlägg in the setting label? It's less repetition, but would force a specific ordering of the text groups and possibly cause issues with circular dependencies if encouraged.

Yes, I do. I think the best way is to add an internal (non-exported) string

const my_posts = "Mina inlägg";

above export const general = { (with an empty line in between) and then use it for both general.my_posts and preferences.general.replace_followed_threads_link. In general, you can just do

my_posts,

rather than

my_posts: my_posts,

since the names are identical.