New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adaptive width style #28
Add adaptive width style #28
Conversation
a5f7f00
to
7cef88a
Compare
Beta.2
Install testing build beta.2Testing build built from 7cef88a |
Den saknas på bland annat:
Villkoret blir väldigt komplicerat oavsett om man gör white- eller blacklist, så jag hade helst kört en "går det så går det"-lösning som misslyckas i tystnad på sidor som saknar En annan lösning skulle kunna vara att bara låta |
527985a
to
61e9cac
Compare
Maybe I should just have the operation in my own fork where I don't really care about having errors in the console. I'm probably the only one who makes use of it anyway. Anyway, I made some changes, let's see where they take us. Beta.3
Install testing build beta.3Testing build built from 61e9cac |
The one thing I'm completely sure about is that you should not keep this feature to your fork, because it's a very nice feature. :) I think it might be possible to do it with CSS only; otherwise, I think the best solution is to decide whether to apply the style based on the path – i.e. something like EDIT: I had not checked out the Beta 3 code when I wrote this comment. EDIT 2: There seems to be a lot of weird |
Tack, bra förklarat!
Vi vill dock inte gärna göra den här typen av modifieringar med DOM-operationer, eftersom det innebär att sidan laddas in och sedan ändras bredden på huvudinnehållet. Det ser inte bra ut och är mycket irriterande i synnerhet på långsammare uppkopplingar. Vi bör göra allt för att lösa detta med CSS. Ska för övrigt nämna att vi ej vill röra |
61e9cac
to
b6674e2
Compare
Fan vad jag älskar att du är envis! Jag skrev om kolumndelen med flex och strösslade med lite magi och det ser faktiskt ut som att det fungerar med bara CSS nu. Jag vågar inte påstå att jag har någon susning om varför eller hur det funkar, men det kan man klura på någon annan dag. Beta.4
Install testing build beta.4Testing build built from b6674e2 |
b6674e2
to
b277532
Compare
No new bugs have been reported and the new CSS looks like it's working well. Let's get this wheel spinning for real now. RC.1
Install release candidate 1built from b277532 |
Största frågetecknet från min sida är var rutan i inställningarna ska vara. |
Tycker den ska ligga under Allmänt ( |
b277532
to
3fbe365
Compare
There are two more things I would like to bring up before merging:
|
3fbe365
to
02620f1
Compare
There was a request to make articles as wide as the forum. I have had this functionality in my fork for a while, but because of a tricky condition that I didn't bother fixing, I never submitted a PR for it... until now! The condition is still not fixed, but maybe @SimonAlling has a good idea of how to either figure the entire condition out or make an acceptable workaround.
If anyone wants to try it out without building themselves, I've provided a testing build below. If you have any feedback you can comment here or @ me in the official Better SweClockers thread.
Install testing build beta.1
Testing build built from a5f7f00