Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form data parse issue #99

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Form data parse issue #99

merged 2 commits into from
Apr 22, 2020

Conversation

NZE
Copy link
Contributor

@NZE NZE commented Apr 22, 2020 •
edited

hey Simon,

As per discussion, I've updated the test.html to have 2 buttons.

  1. First button will parse the response to text as it used to do
  2. Second button will parse the response to FormData object and show the query result then download the uploaded file

I also took the liberty to update the Response Writer to add name to first form part, which fixed my parsing error (using fetch().formData()) and updated the test accordingly. :)

NZE added 2 commits April 22, 2020 13:25
@NZE
fixed issue fetch cannot parse response to FormData
70af813 
1. added name to the query result
2. change test in sample web to be able to download files
3. updated test accordingly
@NZE
update readme.md
04858dc
@SimonCropp SimonCropp merged commit da03ea3 into SimonCropp:master Apr 22, 2020
@SimonCropp SimonCropp added this to the 1.0.1 milestone Apr 22, 2020
@SimonCropp SimonCropp added the Bug label Apr 22, 2020
@NZE NZE deleted the formData-parse-issue branch May 27, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NZE @SimonCropp