Add failing test for toc in file with no headings #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@claremacrae thanks for the PR. can u try 21.0.1 |
I can confirm that 21.0.1 does put the placeholder text in place when there are no headings. And also, if I later add a heading and rerun, that heading does correctly get inserted inside the placeholder toc tags! I'm using this in a private GitHub wiki repo, to add tables of contents, now that inplace generation is supported. Great stuff! Thanks @SimonCropp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://twitter.com/ClareMacraeUK/status/1300386326852915200
This adds a test case for that scenario.
In the verified file, I opted for leaving this text in place if there are no headings present: