Iframe resize fixes #134
Closed
Iframe resize fixes #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to just be protocol + host + port.
frankier
force-pushed
the
iframe-resize-fixes
branch
from
e4a0ed6
to
d8f3124
Compare
|
This helps with running on binder in iframe mode MakieOrg/Makie.jl#2405 |
|
Hey, |
|
I'll close this for now, since it isn't really needed anymore, I think ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently iframe resizing isn't working well when there are multiple iframes on one page. This PR cleans up the iframe resize script injected into the host page and makes it a bit more robust.