Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arni/extract henry coeff #100

Merged
merged 19 commits into from Apr 11, 2019
Merged

Arni/extract henry coeff #100

merged 19 commits into from Apr 11, 2019

Commits on Jan 18, 2019

  1. Add extract_henry_coefficient function along with tests for it

    @Surluson
    Surluson committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    362c877 View commit details
    Browse the repository at this point in the history

  2. Added a functionality to fit a isotherm to a basic langmuir model

    @Surluson
    Surluson committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    a006a8f View commit details
    Browse the repository at this point in the history

  3. Added a new test module, misc_test.jl

    @Surluson
    Surluson committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    1b72f69 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2019

  1. Add a RMSE error to and changed the langmuir fit procedure

    @Surluson
    Surluson committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    ca216a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. Update initial guesses for langmuir fit and allow for a linear method… 

    …. Added tests
    @Surluson
    Surluson committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    c0f78aa View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Redid the fit_isotherm functionality. Now takes in model, suchas henr… 

    …y or langmuir
    @Surluson
    Surluson committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    eb2809c View commit details
    Browse the repository at this point in the history

  2. Remove dependancy on MultivariateStats. Fitting procedure is purely d… 

    …one with Optim.jl now
    @Surluson
    Surluson committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    4749b26 View commit details
    Browse the repository at this point in the history

  3. Reworked tests to apply correctly to the new fitting procedure

    @Surluson
    Surluson committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    871b2f3 View commit details
    Browse the repository at this point in the history

  4. Fixed merger

    @Surluson
    Surluson committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    9767501 View commit details
    Browse the repository at this point in the history

  5. Fixed mistake in misc_test.jl

    @Surluson
    Surluson committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    6d5295a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2019

  1. Removed old functions and added docstring to

    @Surluson
    Surluson committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    4b403e0 View commit details
    Browse the repository at this point in the history

  2. Add Optim.jl to REQUIRE

    @Surluson
    Surluson committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    cac38ef View commit details
    Browse the repository at this point in the history

  3. Removed old call to MultivariateStats

    @Surluson
    Surluson committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    b7ca417 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Changed how the scaled rmse is scaled

    @Surluson
    Surluson committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    779c310 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. Simplified the fitting procedure for Henry. Func now returns a Dict

    @Surluson
    Surluson committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    1d95b9a View commit details
    Browse the repository at this point in the history

  2. Fixed error in Langmuir guess. Reused more code.

    @Surluson
    Surluson committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    938523b View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Removed old artifacts from code

    @Surluson
    Surluson committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    28a3115 View commit details
    Browse the repository at this point in the history

  2. remove unneccesariy isotherm data, change function name to fit_adsorp… 

    …tion_isotherm, make a few comments
    @CorySimon
    CorySimon committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    7f68e70 View commit details
    Browse the repository at this point in the history

  3. update doc string function name

    @CorySimon
    CorySimon committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    59679f4 View commit details
    Browse the repository at this point in the history