You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had errors when running with julia 0.7 on travis build 426 that were not present in julia 1.0. I dropped support for julia 0.7 with this branch and added testing for julia 1.1
remove "***NOTE: Do not delete the last three comment lines..." from the doc strings.
Please allow CSV to read in the .csv files and skip the lines marked as a comment #. See here for how to do so.
Please put the source of where you got the PengRobinson and VdW params inside the .csv files. It is better here as opposed to the documentation because we should let the user amend these with their own comments and with params from different sources (negating the docs).
ask @ahyork for help with this: to ensure that CSV is up to date to allow reading in comments; I believe this is a recent development.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised EOS script to include VdW EOS along with modified VdW properties csv. Changed gas to fluid and modified docs to include VdW.