Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic rotations #99

Merged
merged 5 commits into from Jan 19, 2019
Merged

Generic rotations #99

merged 5 commits into from Jan 19, 2019

Conversation

SimonEnsemble
Copy link
Owner

add functions to compute generic rotations

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 327

  • 16 of 21 (76.19%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.4%) to 70.27%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generic_rotations.jl 14 15 93.33%
src/Box.jl 2 6 33.33%
Totals Coverage Status
Change from base Build 311: 10.4%
Covered Lines: 1118
Relevant Lines: 1591

💛 - Coveralls

@ahyork
Copy link
Collaborator

ahyork commented Jan 11, 2019

Do we need PR #98? It looks like the changes are incorporated in this PR.

@ahyork
Copy link
Collaborator

ahyork commented Jan 16, 2019

Travis tests pass, here is the link to the build status.

I did a quick search and found this issue. Maybe if @SimonEnsemble checks the OAuth tab in GitHub and the organizations in Travis

@SimonEnsemble
Copy link
Owner Author

@ahyork thanks. I see the authorization when I go to my SimonEnsemble account settings --> applications --> authorized apps. image. The Travis CI didn't run on Arni's PR either. Odd.

@SimonEnsemble SimonEnsemble merged commit 0f88ca4 into master Jan 19, 2019
@SimonEnsemble SimonEnsemble deleted the generic_rotations branch January 19, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants