Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encountered a different space group variable of a VESTA cif file #193

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Encountered a different space group variable of a VESTA cif file #193

merged 3 commits into from
Sep 13, 2023

Conversation

galjos
Copy link
Contributor

@galjos galjos commented Sep 12, 2023

crystal.jl: Added a different space group variable and a suitable test cif file that contains the sayed space group variable name.

@eahenle
Copy link
Collaborator

eahenle commented Sep 12, 2023

Thanks @galjos for the PR! Looks like the CI check failed because the new CIF file isn't added to test/data/crystals. Once that's added I can override the formatting check, merge, and make a new release.

@galjos
Copy link
Contributor Author

galjos commented Sep 12, 2023

Oh sorry, I didn't see that the CIF file was not added. And now I had to forcefully stage it.

@eahenle
Copy link
Collaborator

eahenle commented Sep 13, 2023

Yeah, the .gitignore prevents tracking of the test/data directory, because running tests generates a bunch of files, and that gets annoying in git pretty fast. Believe it or not, this isn't the first time a file has gone "missing" this way 😉

@codecov-commenter
Copy link

Codecov Report

Merging #193 (2b3cbe4) into master (9899e9a) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files           8        8           
  Lines         986      986           
=======================================
  Hits          907      907           
  Misses         79       79           
Files Changed Coverage Δ
src/crystal.jl 93.77% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eahenle eahenle merged commit cf9ca96 into SimonEnsemble:master Sep 13, 2023
5 of 7 checks passed
@galjos galjos deleted the spaceGroupVariable branch September 13, 2023 09:20
@eahenle
Copy link
Collaborator

eahenle commented Sep 13, 2023

@galjos Changes are live in the new registered version. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants