Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite CreateFactory() method #4

Closed
SimonG96 opened this issue Jun 4, 2019 · 1 comment
Closed

Rewrite CreateFactory() method #4

SimonG96 opened this issue Jun 4, 2019 · 1 comment
Assignees
@SimonG96
Labels
enhancement New feature or request
Projects
Lightweight IOC Container
Milestone
Backlog

Comments

@SimonG96
Copy link
Owner

SimonG96 commented Jun 4, 2019

Rewrite CreateFactory() method in TypedFactoryRegistration.

Decide how to change it for better readability and maintainability.

See here for problems with the current implementation.
@SimonG96 SimonG96 added the enhancement New feature or request label Jun 4, 2019
@SimonG96 SimonG96 added this to the Backlog milestone Jun 4, 2019
@SimonG96 SimonG96 self-assigned this Jun 4, 2019
@SimonG96 SimonG96 added this to To do in Lightweight IOC Container via automation Jun 4, 2019
@SimonG96 SimonG96 mentioned this issue Jun 4, 2019
Closed
SimonG96 referenced this issue Jun 6, 2019
@SimonG96
- fix IL code generation in TypedFactoryRegistration
c773fdc 
- change signature of Resolve(Type, object[]) back to this correct one
@SimonG96 SimonG96 moved this from To do to In progress in Lightweight IOC Container Jun 6, 2019
@SimonG96
Copy link
Owner Author

SimonG96 commented Jul 5, 2019

This should be okay in it's current state.

@SimonG96 SimonG96 closed this as completed Jul 5, 2019
Lightweight IOC Container automation moved this from In progress to Done Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonG96 SimonG96

Labels
enhancement New feature or request
Projects
Lightweight IOC Container
  
Done
Milestone
Backlog
Development

No branches or pull requests
1 participant
@SimonG96