Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems in CreateFactory() method #5

Closed
SimonG96 opened this issue Jun 4, 2019 · 0 comments
Closed

Fix problems in CreateFactory() method #5

SimonG96 opened this issue Jun 4, 2019 · 0 comments
Assignees
@SimonG96
Labels
bug Something isn't working
Projects
Lightweight IOC Container
Milestone
V1.0

Comments

@SimonG96
Copy link
Owner

SimonG96 commented Jun 4, 2019

Fix the important problems with the CreateFactory() method in TypedFactoryRegistration.
This is related to #4, but in contrary to that issue these are important bugs that need to be fixed as soon as possible.

See here for problems with the current implementation.
@SimonG96 SimonG96 self-assigned this Jun 4, 2019
@SimonG96 SimonG96 added the bug Something isn't working label Jun 4, 2019
@SimonG96 SimonG96 added this to To do in Lightweight IOC Container via automation Jun 4, 2019
@SimonG96 SimonG96 added this to the V1.0 milestone Jun 4, 2019
@SimonG96 SimonG96 moved this from To do to In progress in Lightweight IOC Container Jun 5, 2019
SimonG96 added a commit that referenced this issue Jun 5, 2019
@SimonG96
- really push an empty array onto the stack (#5)
94cc484
SimonG96 added a commit that referenced this issue Jun 5, 2019
@SimonG96
- size of the created array should only be the number of arguments (#5)
42cc514
SimonG96 referenced this issue Jun 6, 2019
@SimonG96
- fix IL code generation in TypedFactoryRegistration
c773fdc 
- change signature of Resolve(Type, object[]) back to this correct one
@SimonG96 SimonG96 moved this from In progress to Testing in Lightweight IOC Container Jun 6, 2019
@SimonG96 SimonG96 moved this from Testing to Done in Lightweight IOC Container Jun 7, 2019
@SimonG96 SimonG96 closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonG96 SimonG96

Labels
bug Something isn't working
Projects
Lightweight IOC Container
  
Done
Milestone
V1.0
Development

No branches or pull requests
1 participant
@SimonG96