docs(readme): fix potential issue in housekeeping #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude tags with multiple digits per position for MAJOR, MINOR and PATCH-Versions while housekeeping.
|
Thanks for this finding and the contribution! |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude tags with multiple digits per position for MAJOR, MINOR and PATCH-Versions while housekeeping.
Since the
[:digit:]]regex allows only one digit per position, tags with version numbers >9 are deleted during housekeeping (affects MAJOR, MINOR and PATCH). For example, tags in the form 1.0.10 will be deleted. This can lead to consequential problems during publishing.This PR allows multiple digits per position via
[[:digit:]]*for MAJOR, MINOR and PATCH versions, which means that these tags will not be deleted during housekeeping.