Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: request for additional documentation #3

Closed
deniederhut opened this issue Oct 31, 2018 · 3 comments
Closed

DOC: request for additional documentation #3

deniederhut opened this issue Oct 31, 2018 · 3 comments

Comments

@deniederhut
Copy link

In particular, I am not easily able to find:

  1. installation instructions
  2. API documentation
  3. Contributing guide

1. Install

At a minimum, I would like to see git clone <> && python setup.py install. It would be nice to have instructions for a virtual environment manager (pipenv, conda, or virtualenv) and a package manager (pip, or poetry). It would be great if this was submitted to pypi (see this guide).

2. API documentation

It looks like most of your objects have docstrings attached, so sphinx should be able to build this for you.

3. Contributing guide

GitHub will automatically warn new contributors to look at the guide before submitting their first issue/PR -- you can see how to set this up here. At a minimum, I would like to see short descriptions of how you would like people to report issues / submit code for inclusion. It can be nice (for you, if this package should become wildly popular) to include issue templates. In a perfect world there would also be a code of conduct.

Please feel free to reach out to me directly if you would like guidance on any of this.

xref openjournals/joss-reviews#1040

@SimonGreenhill
Copy link
Owner

Added Contributing Guide in 221293e

@SimonGreenhill
Copy link
Owner

SimonGreenhill commented Oct 31, 2018

It's on PyPI here, and I've documented install procedure in e2df469

@SimonGreenhill
Copy link
Owner

And here's the API documentation, committed in 226071c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants