Skip to content

Commit

Permalink
Issue #354: build: Make libbfd non-required again to make GPLv3 opt-o…
Browse files Browse the repository at this point in the history 
…ut easier
  • Loading branch information
@SimonKagstrom
SimonKagstrom committed Nov 21, 2021
1 parent 949c4e3 commit 271ebb7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
find_package (Threads)
if (CMAKE_SYSTEM_NAME STREQUAL FreeBSD OR CMAKE_SYSTEM_NAME STREQUAL Linux)
find_package (Bfd REQUIRED)
find_package (Bfd)
endif()

include(TargetArch)
Expand Down

4 comments on commit 271ebb7

@jonhoo
Copy link

@jonhoo jonhoo commented on 271ebb7 Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this probably doesn't warrant a new release in-and-of itself, but do you have a rough estimate for when you think you might cut the next release?

@SimonKagstrom
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't have any specific plans, but if it's important it's quick to do.

I'll have to verify that it still works without libbfd, which I'll admit I haven't done. :-)

@jonhoo
Copy link

@jonhoo jonhoo commented on 271ebb7 Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in a rush, v38 works okay where I am at the moment. It's preventing upgrading to v39, which is a little sad given the nice fixes like #366, but not immediate timeline is necessary :)

@SimonKagstrom
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me if it becomes pressing and I'll make one. Will be the smallest release ever!

Please sign in to comment.