Unpack struct file_data #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packing the structure brings no benefit on 32bit systems and plugs a marginal hole of 4 bytes on 64bit architectures. It also creates a misaligned starting point for the entries[] flex array at the end and while this is typically not a problem for x86 it is reported by GCC with the address-of-packed-member warning. Closes SimonKagstrom#311
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 70.18% 70.18%
=======================================
Files 57 57
Lines 3706 3706
=======================================
Hits 2601 2601
Misses 1105 1105
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packing the structure brings no benefit on 32bit systems and plugs a
marginal hole of 4 bytes on 64bit architectures. It also creates a
misaligned starting point for the entries[] flex array at the end and
while this is typically not a problem for x86 it is reported by GCC
with the address-of-packed-member warning.
Closes #311