Skip to content

Commit

Permalink
[svn r2683] C-API: replaced findOrBuildNodeNs() by more generic findO…
Browse files Browse the repository at this point in the history
…rBuildNodeNsPrefix()

--HG--
branch : trunk
  • Loading branch information
scoder committed Jul 21, 2007
1 parent 1cdb9fc commit 0025063
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
3 changes: 3 additions & 0 deletions CHANGES.txt
Expand Up @@ -48,6 +48,9 @@ Bugs fixed
Other changes
-------------

* In the public C-API, ``findOrBuildNodeNs()`` was replaced by the more
generic ``findOrBuildNodeNsPrefix``

* major refactoring in XPath/XSLT extension function code


Expand Down
3 changes: 0 additions & 3 deletions TODO.txt
Expand Up @@ -62,9 +62,6 @@ lxml 2.0

* always use ns-prefixed type names in objectify's ``xsi:type`` attributes

* remove ``findOrBuildNodeNs()`` from C-API (replaced by
findOrBuildNodeNsPrefix)

* follow PEP 8 in API naming (avoidCamelCase in_favour_of_underscores)

* clean support for entities (is the Entity element class enough?)
Expand Down
4 changes: 0 additions & 4 deletions src/lxml/etreepublic.pxd
Expand Up @@ -197,10 +197,6 @@ cdef extern from "etree.h":
# append an element to the children of a parent element
cdef void appendChild(_Element parent, _Element child)

# recursively lookup a namespace in element or ancestors, or create it
cdef tree.xmlNs* findOrBuildNodeNs(_Document doc, tree.xmlNode* c_node,
char* href)

# recursively lookup a namespace in element or ancestors, or create it
cdef tree.xmlNs* findOrBuildNodeNsPrefix(
_Document doc, tree.xmlNode* c_node, char* href, char* prefix)
Expand Down
6 changes: 0 additions & 6 deletions src/lxml/public-api.pxi
Expand Up @@ -137,12 +137,6 @@ cdef public void iteratorStoreNext(_ElementIterator iterator, _Element node):
cdef public void initTagMatch(_ElementTagMatcher matcher, tag):
matcher._initTagMatch(tag)

cdef public tree.xmlNs* findOrBuildNodeNs(_Document doc, xmlNode* c_node,
char* href) except NULL:
if doc is None:
raise TypeError
return doc._findOrBuildNodeNs(c_node, href, NULL)

cdef public tree.xmlNs* findOrBuildNodeNsPrefix(
_Document doc, xmlNode* c_node, char* href, char* prefix) except NULL:
if doc is None:
Expand Down

0 comments on commit 0025063

Please sign in to comment.