Skip to content

Commit

Permalink
Properly use context runId
Browse files Browse the repository at this point in the history
  • Loading branch information
Simon Scholz committed Sep 19, 2023
1 parent aab22e7 commit 4c826f5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/cardSection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function createCardV2Section(): object[] {
text: 'Go to action run',
onClick: {
openLink: {
url: `https://github.com/${repoPath}/actions/runs/${github.context.runNumber}/job/${github.context.runId}`
url: `https://github.com/${repoPath}/actions/runs/${github.context.runId}/job/${github.context.job}`
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/notificationSender.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export async function notifyGoogleChat(
},
body
})
if (response.status >= 200 && response.status <= 299) {
if (response.status < 200 && response.status > 299) {
throw new Error(
`Google Chat notification failed! error-response=${response.body} status=${response.status}`
)
Expand Down

0 comments on commit 4c826f5

Please sign in to comment.